asciicast of build a test app #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseldess
force-pushed
the
test-app-asciicast
branch
2 times, most recently
from
014a89a to
ddc39ed
Compare
|
Small nit that it doesn't demo the transaction model and doesn't mention that it doesn't. Other than that Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
jseldess
force-pushed
the
test-app-asciicast
branch
from
ddc39ed to
b329ff8
Compare
|
Thanks, Sean. I worked in mention that the transaction-specific code is not covered. Review status: 0 of 4 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Simran-B
added a commit
to Simran-B/docs
that referenced
this pull request
Aug 21, 2025
…feature (cockroachdb#937) * Add security warning to deployments page * Add section about root password rotation * Minor adjustments * Apply suggestions from code review * Add intro for feature * Update deployments.md * Update screenshot Co-authored-by: ansoboleva <93702078+ansoboleva@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add asciicast to
build-a-test-app.mdand clean up steps a bit.Fixes #936
This change is