drpcmetadata: ensure metadata immutability by returning copy #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents mutation of metadata maps stored in context by ensuring Get() returns a copy and Add()/AddPairs() work with copies rather than modifying the original map in place.
shubhamdhama
added a commit
to shubhamdhama/cockroach
that referenced
this pull request
Sep 24, 2025
Changes: - [PR cockroachdb#16: drpcwire: replace drpcerr with gRPC status protobuf for error marshaling](cockroachdb/drpc#16) - [PR cockroachdb#17: drpcmetadata: ensure metadata immutability by returning copy](cockroachdb/drpc#17) Release note: none Epic: none
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Sep 24, 2025
154009: go.mod: bump drpc to 78d4e121902a r=shubhamdhama a=shubhamdhama Changes: - [PR #16: drpcwire: replace drpcerr with gRPC status protobuf for error marshaling](cockroachdb/drpc#16) - [PR #17: drpcmetadata: ensure metadata immutability by returning copy](cockroachdb/drpc#17) Release note: none Epic: none Fixes: #153885 Co-authored-by: Shubham Dhama <shubham.dhama@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents mutation of metadata maps stored in context by ensuring Get() returns a copy and Add()/AddPairs() work with copies rather than modifying the original map in place.