Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design Review: Update badge component font #122

Open
Annebirzin opened this issue Aug 23, 2020 · 1 comment
Open

Design Review: Update badge component font #122

Annebirzin opened this issue Aug 23, 2020 · 1 comment
Assignees
@nathanstilwell
Labels
✨ improvement Adding functionality or adjustment to a component or ui element

Comments

@Annebirzin
Copy link
Collaborator

Annebirzin commented Aug 23, 2020 •
edited
Loading

Update badge component font to match Figma design system.

  • Current implementation in story book uses a lighter font-weight and letter spacing:

Screen Shot 2020-08-23 at 1 16 14 PM

  • Update to font-weight: 600, letter-spacing: 1.5px (just the badge component not all storybook fonts)

Screen Shot 2020-08-23 at 1 17 23 PM

  • This aligns with the H6 font in the Figma design system:

Screen Shot 2020-08-23 at 1 23 44 PM

Screen Shot 2020-08-23 at 1 18 28 PM
@Annebirzin Annebirzin added the 🪲 bug Something isn't working label Aug 23, 2020
@Annebirzin Annebirzin added ✨ improvement Adding functionality or adjustment to a component or ui element and removed 🪲 bug Something isn't working labels Aug 23, 2020
@Pika-Pool
Copy link

So you just want to add these new style properties to the badge component, that's all right? change nothing else? I can do that

nathanstilwell pushed a commit that referenced this issue Oct 17, 2022
fixes #122: Updating Badge font styles
0645525
nathanstilwell pushed a commit that referenced this issue Oct 17, 2022
fixes #122: Updating Badge font styles
22df1f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathanstilwell nathanstilwell

Labels
✨ improvement Adding functionality or adjustment to a component or ui element
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nathanstilwell @Pika-Pool @Annebirzin