feat: add graceful shutdown and refactor validation pipeline #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add signal handling (SIGTERM/SIGINT) with proper cleanup using parent/child stopper contexts - Check for pending jobs on source table before validation to prevent conflicts - Refactor validation steps into uniform pipeline with better error reporting Fixes: #20
BramGruneir
approved these changes
Oct 3, 2025
| } | ||
|
|
||
| // Execute steps | ||
| for _, step := range steps { |
There was a problem hiding this comment.
Is a full state machine really needed here? It's fine I guess, just seems over-complicated. And is begging for a test. You could just repeat a check for is stopping between the calls. Anyway, up to you.
There was a problem hiding this comment.
I had the check repeated originally, I decided to refactor it to make the steps more declarative.
I guess it's just matter of preference. As per the testing, it's covered in the minio integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20