-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loadRes() to work with both Python 2 and 3. #50
base: master
Are you sure you want to change the base?
Conversation
If you want to avoid exceptions, you could use |
@hosang Good idea! Would this block merging the pull request? If so, I'll make the update. Otherwise, I think it's also common in Python to use exceptions for such cases. I've seen it used often in handing unavailable imports, converting strings to numbers, and so on. |
Can someone merge this please! Your code is broken on Python 3 and this fixes it. It's been months since I did this pull request, and it's a tiny one. What's the hold up? |
Fix loadRes() to work with both Python 2 and 3.
+1 |
Wondering why this isn't merged yet? |
Is there a reason why this pull request isn't merged yet? |
There is an alternaitive repo with the error rectified. |
This issue needs to be resolved. There are now at least three public forks to address py3 compatibility and use of numpy. This level of fracture is unnecessary in this case. |
Please merge this request! It's a simple button press.. thanks. |
Why this branch still not merged?? Is there anybody in charge? |
In case anybody is thinking why is the PR still not merged, I think there is no need for merging as the current code checks the 'PYTHON_VERSION' before checking for Unicode equality. So, there won't be any undefined name error. |
@Akhil-Raj so should it be working as is? no need to use waleedka's fork? @pdollar can you merge it? or it should be working even without merging this PR? |
That's not true (at least for
The same thing happens with installation from git (rev. 8c9bcc3). |
This is a small fix for issue #49 to let loadRes() work on Python 2 & 3.