configコマンドの追加 #3 #10 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoide
reviewed
Sep 7, 2023
Comment on lines
+14
to
+21
| var ( | ||
| configKey = [...]string{"api-key", "language", "format"} | ||
| configOption = [][]string{ | ||
| {}, | ||
| {"Japanese", "English"}, | ||
| {"Format 1", "Format 2"}, | ||
| } | ||
| ) |
There was a problem hiding this comment.
他のpackageでも参照する予定だから、enumパッケージ等作成して(objectでもいいかな)欲しいかも！
例
type Format int
const(
PrefixFormat Format = itoa
EmojiFormat
)
→
これを
enum.PrefixFormatみたいに使う感じ
あとentityにも結びつけられたらいいかな
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連issue
Close #3
Close #10
新規追加
configコマンドを追加レビュー時に見てもらいたいこと
特に以下の三か所
entity.config.ChatGptTokenからentity.config.ChatGptApiKeyへの変更util.loadenvの削除