Skip to content

fix(lancedb): unsupport Union types for lancedb target #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix(lancedb): unsupport Union types for lancedb target #1035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions python/cocoindex/targets/lancedb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ def _convert_basic_type_to_pa_type(basic_type: BasicValueType) -> pa.DataType:
"OffsetDateTime": pa.timestamp("us", tz="UTC"),
"TimeDelta": pa.duration("us"),
"Json": pa.json_(),
"Union": pa.json_(),
}

if kind in type_mapping:
Expand All @@ -142,7 +141,7 @@ def _convert_basic_type_to_pa_type(basic_type: BasicValueType) -> pa.DataType:
# Range as a struct with start and end
return pa.struct([pa.field("start", pa.int64()), pa.field("end", pa.int64())])

assert False, f"Unsupported type kind: {kind}"
assert False, f"Unsupported type kind for LanceDB: {kind}"


def _convert_key_value_to_sql(v: Any) -> str:
Expand Down Expand Up @@ -174,16 +173,19 @@ def _convert_fields_to_pyarrow(fields: list[FieldSchema], v: Any) -> Any:
return {field.name: _convert_value_for_pyarrow(field.value_type.type, v)}


def _convert_value_for_pyarrow(t: ValueType | None, v: Any) -> Any:
if t is None or isinstance(t, BasicValueType):
def _convert_value_for_pyarrow(t: ValueType, v: Any) -> Any:
if v is None:
return None

if isinstance(t, BasicValueType):
if isinstance(v, uuid.UUID):
return v.bytes

if isinstance(v, tuple) and len(v) == 2:
if t.kind == "Range":
return {"start": v[0], "end": v[1]}

if isinstance(v, list):
return [_convert_value_for_pyarrow(None, value) for value in v]
if t.vector is not None:
return [_convert_value_for_pyarrow(t.vector.element_type, e) for e in v]

return v

Expand Down
Loading