Skip to content

Conversation

georgeh0
Copy link
Member

@georgeh0 georgeh0 commented Sep 26, 2025

stop gap for #1051

@georgeh0 georgeh0 requested a review from Copilot September 26, 2025 02:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation to prevent the use of unsupported vector indexing configuration options across multiple database targets. The changes ensure that appropriate error messages are raised when users attempt to configure vector index methods or vector indexes themselves on targets that don't yet support these features.

Key changes:

  • Add method configuration validation for Qdrant and Neo4j targets
  • Add vector index support validation for Kuzu and LanceDB targets

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/ops/targets/qdrant.rs Adds validation to reject vector index method configuration
src/ops/targets/neo4j.rs Adds validation to reject vector index method configuration
src/ops/targets/kuzu.rs Adds validation to reject vector indexes entirely
python/cocoindex/targets/lancedb.py Adds validation to reject vector index method configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@georgeh0 georgeh0 merged commit 685b76e into main Sep 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant