Skip to content

Conversation

princyballabh
Copy link
Contributor

  • Enhanced load_engine_object() to automatically apply safe defaults for missing fields
  • Uses existing _get_auto_default_for_type() function to determine safe defaults:
    • Optional[T]None
    • list[T][]
    • dict[K,V]{}
  • Respects explicit defaults when available
  • Maintains backward compatibility

Copy link
Member

@georgeh0 georgeh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the PR!

@georgeh0
Copy link
Member

georgeh0 commented Oct 2, 2025

Hi @princyballabh,

Thanks for the PR. Would you please rerun precommit hooks, which will automatically reformat files:

pre-commit install
pre-commit run --all-files

@georgeh0
Copy link
Member

georgeh0 commented Oct 2, 2025

This resolves #1086

@georgeh0 georgeh0 merged commit 069f4a1 into cocoindex-io:main Oct 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants