Optimize parse integer list #19627

JohnCoconut · 2019-04-19T07:54:09Z

Same PR (#19619) as the v3 branch. The comment from v3 PR is copied below.

In file cocos/2d/CCSpriteFrameCache.cpp, the function SpriteFrameCache::parseIntegerList calls

res[i++] = atoi(string.substr(start, end - start).c_str());

in a loop, which is bad for performance, as substr() function construct a new string and destruct it in every loop iteration.

The new function use strtol, which does not create new string. It's nearly twice as fast as the old one, according to google benchmark.

http://quick-bench.com/JjzXDobBEloaspNT0nOPC7EO9m4

Don’t hide the home indicator, instead „disable“ it. So the user has to double tap it to use it. It’s tinted to be nearly invisible over the content.

…true (cocos2d#19107)

Bugfix for aviod reading outside of the buffer. If new will allocate memory at the end of the heap - reading of MAX_LOG_LENGTH from memory would cause access violation reading location.

…18993) * add line spacing support for system font on iOS and Android * correct para flag IIIIIIIIZFFFFZIIIIFZI IIIIIIIIFZFFFFZIIIIFZI

* Add `GLView::setCursor` for desktop platforms * Add test for custom mouse cursor

…tomatically (cocos2d#19141)

* modern cmake, use target_compile_definitions partly * simplify macro define, remove USE_* * modern cmake, macro define * add physics 2d macro define into ccConfig.h * remove USE_CHIPMUNK macro in build.gradle * remove CocosSelectModule.cmake * shrink useless define * simplify compile options config, re-add if necessary * update external for tmp CI test * un-quote target_compile_options value * add "-g" parameter only when debug mode * keep single build type when generator Xcode & VS projecy * update external for tmp CI tes * add static_cast<char>(-1), fix -Wc++11-narrowing * simplify win32 compile define * not modify code, only improve compile options

…tomatically (cocos2d#19142)

Just checked for the loading bar target and cast appropriately. I made this edit in Github, but the source edit was from my old fork that I can't get to merge in tankorsmash/cocos2dx-mytracker@aac2a0b

* cmake_compiler_flags * Fix typo * Fix typo2 * Remove chanages from Android.mk

in `BitmapDC::sizeWithText` and `BitmapDC::drawText`, use DT_HIDEPREFIX flag for ignoring the ampersand (&) prefix character in the text. we don't need to handle ampersands ourselves refer [MSDN](https://docs.microsoft.com/zh-cn/windows/desktop/api/winuser/nf-winuser-drawtextexw)

* don't add -Wno-deprecated into jsb target * correct lua template cmake build * fix win32 lua template compile error

…tomatically (cocos2d#19152)

…ocos2d#19153)

* fix image locator * update assertion

* re-target on wi10 for win32 project * fix js-tests sources copy * fix lua tests * fix js template * remove libbox2d.vcxproj ref * improve js source copy * copy source in post build event * little improve * update external

* fix FileUtils::getContents on linux/mac * use stat.st_mode * simplify

…rtions ccdata remove copy assertions

* fix wrong png convert format from sRGB to Gray * erase plist index if all frames was erased * test_A8.png have I8 format, fix it

* trucate label text * modify log value

* win32 getFileSize * fix stat

Will be useful.

Getting current clearing color in Renderer

Changing tabs to spaces and getters for claring color

…tomatically

…1552959478 [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically

Ability to change title position

…ue has actually changed. (cocos2d#19556)

…tomatically (cocos2d#19563)

There is an unmatched ");" in the file at line 720.

* Fix bug: can't play video in obbfile. * Change check order.

The token array shouldn't be static in CCPUScriptTranslator.h, otherwise including it will generate duplicate token array.

* Update UIDeprecated.cpp There is no need of this last "}". * End the NS_CC properly. Change the "}" with NS_CC_END to avoid misunderstandings.

* add build test option for cmake * configure build test option for cmake

…sed is a single character string literal. The character literal overload is more efficient. (cocos2d#19614)

minggo · 2019-04-19T08:40:56Z

Oh, it seems it is a bad PR. You should check out the branch based on metal-support branch, then modify it.

minggo · 2019-04-19T08:43:19Z

You can do like this:

checkout a branch based on metal-support branch
use git cherry-pick to check the commit

The commit id may be different from your local commit id, because every PR is merged by rebase.

JohnCoconut · 2019-04-19T10:31:28Z

@minggo

The commit id may be different from your local commit id, because every PR is merged by rebase.

Sorry, but I am not sure what you mean. I am unfamiliar with git cherry-pick. I just cherry-picked a local commit, pushed it to my fork, and made a PR. No conflict now. Am I doing it right?

#19629

Shall I close this PR if I am doing it correctly. You can close it too if it's ok.

minggo · 2019-04-19T10:45:33Z

The new PR looks good.

mars3142 and others added 30 commits October 31, 2018 16:54

iPhone X home indicator handling (cocos2d#19132)

54f377f

Don’t hide the home indicator, instead „disable“ it. So the user has to double tap it to use it. It’s tinted to be nearly invisible over the content.

Fix bug: Not support sprite frame when ignoreContentAdaptWithSize is …

18a14fb

…true (cocos2d#19107)

Bugfix for aviod reading outside of the buffer. (cocos2d#19098)

b372ce3

Bugfix for aviod reading outside of the buffer. If new will allocate memory at the end of the heap - reading of MAX_LOG_LENGTH from memory would cause access violation reading location.

add line spacing support for system font on iOS and Android (cocos2d#…

89e75ee

…18993) * add line spacing support for system font on iOS and Android * correct para flag IIIIIIIIZFFFFZIIIIFZI IIIIIIIIFZFFFFZIIIIFZI

Add GLView::setCursor for desktop platforms (cocos2d#19129)

0e966a7

* Add `GLView::setCursor` for desktop platforms * Add test for custom mouse cursor

[ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json au…

1fda31b

…tomatically (cocos2d#19141)

[ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json au…

4315f56

…tomatically (cocos2d#19142)

add ui::LoadingBar support to Progress actions (cocos2d#18748)

e5b77ad

Just checked for the loading bar target and cast appropriately. I made this edit in Github, but the source edit was from my old fork that I can't get to merge in tankorsmash/cocos2dx-mytracker@aac2a0b

modern cmake, improve cmake_compiler_flags (cocos2d#19145)

bb54367

* cmake_compiler_flags * Fix typo * Fix typo2 * Remove chanages from Android.mk

modern cmake, cmake_cleanup_remove_unused_variables (cocos2d#19146)

89cf910

correct lua template cmake build (cocos2d#19149)

304703f

* don't add -Wno-deprecated into jsb target * correct lua template cmake build * fix win32 lua template compile error

UIButton fix setTitleLabel memleaks (cocos2d#19148)

581c201

prevent cmake in-source-build friendly (cocos2d#19151)

77ae57e

[ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json au…

e63e00f

…tomatically (cocos2d#19152)

make code more clean and make comment more clear (cocos2d#19155)

bb32eee

Action::Repeat fix NaN error (cocos2d#19158)

2e76641

Copy resources to "Resources/" on win32 like in linux configuration (c…

8a142cb

…ocos2d#19153)

[TiledMap] locate image path relative to tsx file (cocos2d#19147)

dc14250

* fix image locator * update assertion

go on, Copy resources to "Resources/" on win32 (cocos2d#19166)

ae61f8f

* re-target on wi10 for win32 project * fix js-tests sources copy * fix lua tests * fix js template * remove libbox2d.vcxproj ref * improve js source copy * copy source in post build event * little improve * update external

update cocos cmd, disable "gen-libs" (cocos2d#19167)

387e1a7

[linux] Fix FileUtils::getContents with folder (cocos2d#19157)

aa52eee

* fix FileUtils::getContents on linux/mac * use stat.st_mode * simplify

remove assertions

ec05612

Merge pull request cocos2d#19172 from PatriceJiang/ccdata_remove_asse…

1d44c9a

…rtions ccdata remove copy assertions

fix cpp-tests SpritePolygon crash, wrong png format (cocos2d#19170)

8ebf713

* fix wrong png convert format from sRGB to Gray * erase plist index if all frames was erased * test_A8.png have I8 format, fix it

a workaround to fix black screen on macOS 10.14 (cocos2d#19090)

1fe3c17

[CCLabel] trucate label text if too long (cocos2d#19174)

d0d1f67

* trucate label text * modify log value

[CCFileUtils] win32 getFileSize (cocos2d#19176)

1bd2f55

* win32 getFileSize * fix stat

fix crash of cclayercolor and fix some other error logic (cocos2d#19177)

30daf5d

sbrednikhin and others added 24 commits March 15, 2019 11:34

Getting current clearing color in Renderer

80c6a69

Will be useful.

Merge pull request cocos2d#19518 from sbrednikhin/patch-1

7634d12

Getting current clearing color in Renderer

Tabs to spaces

7dbd0d5

Tabs to spaces

e5fa917

Methods of changing clearing color

66dbafe

Getting clearing color from Director interface

9caa7b2

Ability to change title position

b9ff3dd

Merge pull request cocos2d#19520 from sbrednikhin/v3

b16292a

Changing tabs to spaces and getters for claring color

[ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json au…

d8787b4

…tomatically

Merge pull request cocos2d#19525 from CocosRobot/update_lua_bindings_…

a19fae8

…1552959478 [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically

Merge pull request cocos2d#19524 from gestern/patch-1

a3a536e

Ability to change title position

Only send the ON_PERCENTAGE_CHANGED if and only if the percentage val…

78a8b2b

…ue has actually changed. (cocos2d#19556)

[ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json au…

56abd88

…tomatically (cocos2d#19563)

[windows] use PostMessage to replace SendMessage (cocos2d#19569)

a837ed7

revert threads (cocos2d#19572)

14d1ffe

Update CCArmature.cpp (cocos2d#19579)

5dedc9d

There is an unmatched ");" in the file at line 720.

use CC_SAFE_DELETE_ARRAY instead of CC_SAFE_DELETE (cocos2d#19580)

d71ae3f

Fix bug: can't play video in obbfile. (cocos2d#19476)

fc6a6db

* Fix bug: can't play video in obbfile. * Change check order.

fix base/CMakeLists.txt (cocos2d#19575)

b1e4a17

fix static token array in headfile (cocos2d#19164)

f8fb981

The token array shouldn't be static in CCPUScriptTranslator.h, otherwise including it will generate duplicate token array.

End the NS_CC properly. (cocos2d#19603)

1b1a1a4

* Update UIDeprecated.cpp There is no need of this last "}". * End the NS_CC properly. Change the "}" with NS_CC_END to avoid misunderstandings.

add build test option for cmake (cocos2d#19608)

b1e4a16

* add build test option for cmake * configure build test option for cmake

Optimize calls to std::string::find() and friends when the needle pas…

d5021cf

…sed is a single character string literal. The character literal overload is more efficient. (cocos2d#19614)

rewrite parseIntegerList with better performance

28e8a64

minggo closed this Apr 19, 2019

JohnCoconut deleted the optimize-parseIntegerList branch April 19, 2019 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize parse integer list #19627

Optimize parse integer list #19627

JohnCoconut commented Apr 19, 2019

minggo commented Apr 19, 2019

minggo commented Apr 19, 2019 •

edited

Loading

JohnCoconut commented Apr 19, 2019 •

edited

Loading

minggo commented Apr 19, 2019

Optimize parse integer list #19627

Optimize parse integer list #19627

Conversation

JohnCoconut commented Apr 19, 2019

minggo commented Apr 19, 2019

minggo commented Apr 19, 2019 • edited Loading

JohnCoconut commented Apr 19, 2019 • edited Loading

minggo commented Apr 19, 2019

minggo commented Apr 19, 2019 •

edited

Loading

JohnCoconut commented Apr 19, 2019 •

edited

Loading