Fix bug: Not support sprite frame when ignoreContentAdaptWithSize is false #19107
Conversation
| @@ -565,7 +565,7 @@ class CC_GUI_DLL RichText : public Widget | |||
| const Color3B& outlineColor = Color3B::WHITE, int outlineSize = -1, | |||
| const Color3B& shadowColor = Color3B::BLACK, const Size& shadowOffset = Size(2.0, -2.0), int shadowBlurRadius = 0, | |||
| const Color3B& glowColor = Color3B::WHITE); | |||
| void handleImageRenderer(const std::string& filePath, const Color3B& color, GLubyte opacity, int width, int height, const std::string& url); | |||
| void handleImageRenderer(const std::string& filePath, Widget::TextureResType textureType, const Color3B& color, GLubyte opacity, int width, int height, const std::string& url); | |||
There was a problem hiding this comment.
It is better to add a new API, rather than change the current one.
There was a problem hiding this comment.
Thanks, do you mean to provide a new api for using sprite frames?
There was a problem hiding this comment.
@PatriceJiang
And the current one is a little weird, developer can't use sprite frames when they want to set the content size, they have to use a local sprite which is the same as the one in the plist. In a project, using the same sprite with different size at different places is very normal, do you think so? :)
There was a problem hiding this comment.
same sprite with different size
These sprites do share same Texture underlying, but I think they should not be "the same sprite".
A Sprite holds partial render info of a Texture instance. Since the position/size differs, they should be separated.
There was a problem hiding this comment.
The background is: language is javescript, using createWithXML to create richtext.
The case is that:
There is a file, "res/star.png". I want to create two richtexts using the "star" loading from the file, one richtext's _ignoreSize is true, and the other has to be false, then I can't put "res/star.png" into plist, because when _ignoreSize is true, RichText can't load image from plist.
In my project, almost all of the pngs has been put into plist due to resource management and performance.
Am I clear?
There was a problem hiding this comment.
Please open a new issue and provide a description there
There was a problem hiding this comment.
OK, the new issue is #19114
chongchaoyu
changed the title
STEVE: removed js/lua new files from merge * commit 'bb32eee94438f92b61799781211ddd3f5afd7736': make code more clean and make comment more clear (cocos2d#19155) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19152) prevent cmake in-source-build friendly (cocos2d#19151) UIButton fix setTitleLabel memleaks (cocos2d#19148) correct lua template cmake build (cocos2d#19149) modern cmake, cmake_cleanup_remove_unused_variables (cocos2d#19146) refine CCDevice-win32 BitmapDC (cocos2d#19144) modern cmake, improve cmake_compiler_flags (cocos2d#19145) add ui::LoadingBar support to Progress actions (cocos2d#18748) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19142) modern cmake, compile definitions improvement (cocos2d#19139) [ci skip][AUTO]: updating luabinding & jsbinding & cocos_file.json automatically (cocos2d#19141) Add `GLView::setCursor` for desktop platforms (cocos2d#19129) add line spacing support for system font on iOS and Android (cocos2d#18993) Bugfix for aviod reading outside of the buffer. (cocos2d#19098) Fix bug: Not support sprite frame when ignoreContentAdaptWithSize is true (cocos2d#19107) iPhone X home indicator handling (cocos2d#19132) # Conflicts: # build/cocos2d_tests.xcodeproj/project.pbxproj # cocos/base/CCConsole.cpp # cocos/scripting/js-bindings/CMakeLists.txt # cocos/scripting/js-bindings/auto/api/jsb_cocos2dx_auto_api.js # cocos/scripting/js-bindings/auto/jsb_cocos2dx_auto.cpp # cocos/scripting/js-bindings/auto/jsb_cocos2dx_auto.hpp # cocos/scripting/js-bindings/proj.android/CMakeLists.txt # cocos/scripting/lua-bindings/CMakeLists.txt # cocos/scripting/lua-bindings/auto/api/GLView.lua # cocos/scripting/lua-bindings/auto/lua_cocos2dx_auto.cpp # cocos/scripting/lua-bindings/auto/lua_cocos2dx_auto.hpp # templates/js-template-default/CMakeLists.txt # templates/js-template-default/frameworks/runtime-src/proj.android/app/build.gradle # templates/js-template-default/frameworks/runtime-src/proj.ios_mac/ios/RootViewController.mm # templates/lua-template-default/CMakeLists.txt # templates/lua-template-default/frameworks/runtime-src/proj.android/app/build.gradle # templates/lua-template-default/frameworks/runtime-src/proj.ios_mac/ios/RootViewController.mm # tests/js-tests/project/CMakeLists.txt # tests/js-tests/project/proj.android/app/build.gradle # tests/lua-empty-test/project/CMakeLists.txt # tests/lua-empty-test/project/proj.android/app/build.gradle # tests/lua-tests/project/CMakeLists.txt # tests/lua-tests/project/proj.android/app/build.gradle
No description provided.