Skip to content

Add support for building projects with SBT and Maven #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2016

Conversation

rtfpessoa
Copy link
Contributor

@PCManticore @machadoit just moved the builders to this project.

@PCManticore
Copy link

Cool, thanks! Just curious: it's just a move or you modified any code?

@rtfpessoa
Copy link
Contributor Author

I did one fix. I am doing 2 different commits at the moment.

@machadoit
Copy link
Contributor

Yeah it makes sense here, merge when you split into 2 commits

@rtfpessoa rtfpessoa force-pushed the add-builder-support branch from 739193d to 3f81603 Compare April 6, 2016 12:59
@rtfpessoa
Copy link
Contributor Author

@PCManticore just commited. If there was no scala- directory it would create a weird path.

fyi, regarding paths, you should concatenate them with Paths or File apis.

import java.nio.file.Paths
val basePath = Paths.get("/tmp/my/path")
basePath.resolve("mySubDir")                  /tmp/my/path/mySubDir

import java.io.File
new File("/tmp/my/path")                      /tmp/my/path
new File("/tmp/my/path", "mySubDir")          /tmp/my/path/mySubDir

@machadoit
Copy link
Contributor

👍

@rtfpessoa rtfpessoa merged commit 26182d6 into master Apr 12, 2016
@rtfpessoa rtfpessoa deleted the add-builder-support branch April 12, 2016 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants