New Configuration #431
Merged
New Configuration #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new Input Properties. stlModelFiles string[] - List of stl model files
KillerCodeMonkey
requested changes
Dec 21, 2020
| window.addEventListener('resize', this.onWindowResize, false) | ||
|
|
||
| const meshCreations = this.stlModels.map((modelPath, index) => this.createMesh(modelPath, this.meshOptions[index])) | ||
| let meshCreations: any = null; |
There was a problem hiding this comment.
please add the correct type Promise<THREE.Mesh>[]
|
|
||
| const meshCreations = this.stlModels.map((modelPath, index) => this.createMesh(modelPath, this.meshOptions[index])) | ||
| let meshCreations: any = null; | ||
| if (Array.isArray(this.stlModels) && |
There was a problem hiding this comment.
no need to check. default value is an empty array, just check the lengthh
| const geometry: THREE.BufferGeometry = await this.stlLoader.loadAsync(path) | ||
| async createMesh(path: string, meshOptions: MeshOptions = {}, parse: boolean = false): Promise<THREE.Mesh> { | ||
| let geometry: THREE.BufferGeometry = null; | ||
| if (!parse) { |
There was a problem hiding this comment.
please switch the condition so you are checking the truthy case :)
KillerCodeMonkey
requested changes
Dec 22, 2020
| window.addEventListener('resize', this.onWindowResize, false) | ||
|
|
||
| const meshCreations = this.stlModels.map((modelPath, index) => this.createMesh(modelPath, this.meshOptions[index])) | ||
| let meshCreations: Promise<THREE.Mesh>[] = null; |
There was a problem hiding this comment.
one last thing: please set the initial value to an empty array :)
Rocket
KillerCodeMonkey
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Input Properties.
stlModelFiles string[] - List of stl model files