fix: don't generate borsh::to_vec if no borsh traits
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 123ae50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
buffalojoec
force-pushed
the
optional-borsh-callsites
branch
from
40c7842 to
c2cc799
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust renderer supports a configuration object for determining what traits you'd like to be generated in the
#[derive(..)]block of each type. However, if you don't includeBorshSerializeorBorshDeserialize, the renderer will still useborsh::to_vecfor instructions.This PR changes those
borsh::to_veccallsites in the generated instructions to instead useself.try_to_vec()and conditionally implements atry_to_vecmethod that calls intoborsh::try_to_vecif theBorshSerializetrait is implemented.The use of a wrapper function
try_to_vecallows developers to implement their owntry_to_vecas a workaround in case they want to use an alternative serialization method, such as bytemuck. This is current how the generated deserialization code for accounts works accidentally.