Remove JaResource/Canary from RoleController #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Oct 3, 2017
lib/code_corps/model/role.ex
Outdated
| @spec create_changeset(Codecorps.Role.t, map) :: Ecto.Changeset.t | ||
| def create_changeset(struct, params \\ %{}) do | ||
| changeset(struct, params) | ||
| end |
There was a problem hiding this comment.
I see you did the same across several PRs. Sorry for not reviewing earlier and saving you some time, but I think it would be preferable to revert on this and simply call Role.changeset from the controller instead.
landongrindheim
force-pushed
the
901-move-role-controller-from-ja-resources
branch
2 times, most recently
from
2e792d3 to
02899a0
Compare
landongrindheim
force-pushed
the
901-move-role-controller-from-ja-resources
branch
from
02899a0 to
a82fe9a
Compare
|
@begedin Updated! |
landongrindheim
deleted the
901-move-role-controller-from-ja-resources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Remove reliance on JaResource/Canary in RoleController
References
Closes #901
Progress on: #864