Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial changes for removing ja_resource from donation_goal_controller #1025

Conversation

paulsullivanjr
Copy link
Contributor

@paulsullivanjr paulsullivanjr commented Oct 8, 2017

What's in this PR?

Remove ja_resource from DonationGoalController

Closes #889
Progress on: #864

@paulsullivanjr
Copy link
Contributor Author

I'd like to get some help with this if possible. I have 8 failing controller tests around canary. I'm not positive if I need to make these changes in policy.ex and what the right changes are. I still have failing tests if I leave policy.ex in its original state. Any feedback would be appreciated. Thanks!

@vishaldeepak
Copy link
Contributor

Seems to me that you need to make modifications on CodeCorps.Policy.DonationGoal. In this file functions earlier expected a changeset but with the new changes it should expect a map of params. A good example would be in CodeCorps.Policy.ProjectSkill

@begedin
Copy link
Contributor

begedin commented Oct 15, 2017

@paulsullivanjr Hate to do this, but considering the amount of work @landongrindheim put into #1068, I had to merge his PR, since it allowed us the close the milestone in one fell swoop.

Your work here is still very much appreciated. However, since the task is done as part of #1068, I have to close this one.

@begedin begedin closed this Oct 15, 2017
@begedin begedin deleted the 889-switch-donation-goal-controller-away-from-jaresource-and-canary branch October 15, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants