Remove JaResource from StripeConnectPlanController #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Oct 9, 2017
| {:ok, :authorized} <- current_user |> Policy.authorize(:create, %StripeConnectPlan{}, params), | ||
| {:ok, %StripeConnectPlan{} = stripe_platform_plan} <- StripeConnectPlanService.create(params) |> handle_create_result(conn) do | ||
| conn |> put_status(:created) |> render("show.json-api", data: stripe_platform_plan) | ||
| end | ||
| end | ||
|
|
||
| defp handle_create_result({:error, :project_not_ready}, conn) do |
There was a problem hiding this comment.
The changes you made look good.
However, you've managed to point out that the handle_create_result step, which I believe I wrote was and will continue causing problems here, for which I need to create an issue - #1031
begedin
approved these changes
Oct 9, 2017
landongrindheim
deleted the
906-remove-ja-resource-from-stripe-connect-plan-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove JaResource from StripeConnectPlanController
References
Closes #906
Progress on: #864