Remove JaResource for StripeConnectSubscriptions #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Oct 10, 2017
| def create?(user, subscription), do: user |> owns?(subscription) | ||
|
|
||
| @spec show?(User.t, map) :: boolean |
There was a problem hiding this comment.
These specs should be the other way around
@spec create?(User.t, map) :: boolean
def create?(user, params), do: user |> owns?(subscription)
@spec show?(User.t, StripeConnectSubscription.t) :: boolean
def show?(user, subscription), do: user |> owns?(subscription)
| def model, do: CodeCorps.StripeConnectSubscription | ||
| @spec show(Conn.t, map) :: Conn.t | ||
| def show(%Conn{} = conn, %{"id" => id}) do | ||
| with %StripeConnectSubscription{} = subscription <- StripeConnectSubscription |> Repo.get(id) do |
There was a problem hiding this comment.
You're missing an authorization step here.
with %StripeConnectSubscription{} = subscription <- StripeConnectSubscription |> Repo.get(id),
{:ok, :authorized} <- current_user |> Policy.authorize(:create, subscription, params) do # params are optional
conn |> render("show.json-api", data: subscription)
end
landongrindheim
force-pushed
the
907-remove-ja-resource-from-stripe-connect-subscription-controller
branch
from
c916319 to
953fb26
Compare
|
@begedin Thanks for the feedback! Can you take another look to make sure the implementation is correct? I went back to |
|
@landongrindheim Good job noticing that. Feel free to create an issue in cases such as that one. My approach to it is, always better to close an issue when one was made by mistake, than to forget to open it in the first place. |
begedin
approved these changes
Oct 10, 2017
|
Excellent work as always @landongrindheim |
landongrindheim
deleted the
907-remove-ja-resource-from-stripe-connect-subscription-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove JaResource/Canary for StripeConnectSubscriptionController
References
Closes #907
Progress on: #864