Remove JaResource from ProjectGithubRepoController #1046
Conversation
|
|
||
| plug :load_resource, model: ProjectGithubRepo, only: [:show], preload: [:github_repo, :project] | ||
| plug :load_and_authorize_changeset, model: ProjectGithubRepo, only: [:create] | ||
| plug :load_and_authorize_resource, model: ProjectGithubRepo, only: [:delete] |
There was a problem hiding this comment.
@landongrindheim As you can see, we do actually need to support a delete action.
It's not clear here, but we likely also need to support an index action (it's implicit from us having a filter function before). These are the reasons we're switching away from ja_resource. Lot's of hidden stuff.
Basically, the controller needs to support
- index (with id filter)
- show
- create (with authorization)
- delete (with authorization)
There was a problem hiding this comment.
You can use OrganizationGithubAppInstallationController as a sort of template.
landongrindheim
force-pushed
the
898-remove-ja-resource-from-github-project-repo-controller
branch
from
4664b79 to
8b8581d
Compare
|
@begedin I've added |
joshsmith
force-pushed
the
898-remove-ja-resource-from-github-project-repo-controller
branch
from
8b8581d to
9b9f786
Compare
|
@landongrindheim looks great! I just rebased but have to step away for a moment. Feel free to merge once the tests pass. |
|
@joshsmith Merging is blocked for me currently |
|
Sorry about that! Didn't realize. Dismissed review and just merged for you. |
|
Thanks :) |
landongrindheim
deleted the
898-remove-ja-resource-from-github-project-repo-controller
branch
Remove JaResource/Canary from ProjectGithubRepoController
References
Closes #898
Progress on: #864