Remove JaResource from GithubRepoController #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshsmith I see you added the label "good first issue" to the issues in #864. I've been taking them to close out the issue. Do you want me to leave them for first time contributors? |
|
@landongrindheim nope! You can keep working on them. GitHub just added that as a label to their UI so I figured we'd hop on the bandwagon. |
joshsmith
previously approved these changes
Oct 11, 2017
|
Looks good, just needs a rebase thanks to the high churn and you can merge at will! |
landongrindheim
force-pushed
the
891-remove-ja-resource-from-github-repo-controller
branch
from
d21b6cb to
18d9046
Compare
|
@joshsmith I'm not able to self-approve, or merge without a review (the previous review was dismissed by a rebase) Once the PRs that are currently open are approved and merged, it looks like JaResource and Canary will be able to be removed 🎉 |
joshsmith
approved these changes
Oct 12, 2017
|
Ah I keep forgetting the rebase trips it up. Merging now. Thanks! |
landongrindheim
deleted the
891-remove-ja-resource-from-github-repo-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove JaResource from GithubRepoController
References
Closes #891
Progress on: #864