Fix modified_at comparisons to use seconds granularity #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
force-pushed
the
1202-fix-modified-at-comparisons
branch
from
e1162d8 to
f63156d
Compare
joshsmith
force-pushed
the
1202-fix-modified-at-comparisons
branch
from
f63156d to
592e28b
Compare
|
I'm going to merge this without review since it's affecting events in production. @begedin could you look at this ex post facto and tell me if you have any issues with it, and open an issue if so? |
This was referenced Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fixes the way we're doing timestamp comparison to not error when GitHub sends us events with only second-level accuracy.