Refactoring request_update test helper to include default attrs #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackenziehicks
changed the title
joshsmith
reviewed
Nov 2, 2016
| def request_update(conn, :not_found), do: conn |> request_update(-1, %{}) | ||
| def request_update(conn, attrs), do: conn |> request_update(default_record, attrs) | ||
| def request_update(conn, resource_or_id, attrs) do | ||
| def request_update(conn, attrs \\ %{}), do: conn |> request_update(default_record, attrs) |
There was a problem hiding this comment.
I think this line needs to move above not_found.
joshsmith
approved these changes
Nov 2, 2016
mackenziehicks
force-pushed
the
refactor-request-update-test-helper
branch
from
403167b to
fd8bda8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added default attributes to the request_update function in api_case.ex in order to assist with controller test refactoring.
References
Progress on: #413