Added dialyzer locally (not on CI) #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
force-pushed
the
add-dialyzer
branch
2 times, most recently
from
31a169e to
c9c03bd
Compare
|
In the circle_pre_build you may need to |
|
The exit code
|
|
I'm OK with the build failing on exit code 2, though, since it does mean that our specs aren't really correct. |
|
I might suggest running the dialyxir test on a separate line. Should make Circle reporting more transparent. |
begedin
force-pushed
the
add-dialyzer
branch
3 times, most recently
from
ab374b2 to
2db117c
Compare
begedin
changed the title
joshsmith
approved these changes
Feb 2, 2017
| {:error, :project_not_found} | | ||
| {:error, :project_not_ready} | | ||
| {:error, :user_not_found} | | ||
| {:error, :user_not_ready} |
There was a problem hiding this comment.
Maybe remove the doc for the return values since @spec does that?
There was a problem hiding this comment.
I thought I did, definitely did in the other place I added it. Done now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Work in progress, still trying to get it work on CI. I will also have to actually fix reported issues once it does work.
Update: Got the build to fail if there are dialyzer warnings. It also made the build quite long, so need to figure out how to add caching or something.