Skip to content

Conversation

joshsmith
Copy link
Contributor

What's in this PR?

Adds website and should_link_externally columns to Project and exposes them on the view.

@ignu
Copy link
Contributor

ignu commented Mar 8, 2017

LGTM! 🚢 :shipit:

My only feedback is, as someone new to the project, I'm not sure what should_link_externally is for, even after reading the ticket. Is it just opening the project url in a new window?

@joshsmith
Copy link
Contributor Author

@ignu it's going to be very very temporary, but good feedback nonetheless.

@joshsmith joshsmith force-pushed the 739-add-website-field branch from 4756050 to 1e7c6e1 Compare March 9, 2017 00:12
@joshsmith joshsmith removed the request for review from christopherstyles March 9, 2017 00:13
@joshsmith joshsmith merged commit 542b38d into develop Mar 9, 2017
@joshsmith joshsmith deleted the 739-add-website-field branch March 9, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants