Remove UserCategory reliance on ja_resource/canary #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
previously requested changes
Sep 20, 2017
| plug JaResource | ||
| @spec index(Conn.t, map) :: Conn.t | ||
| def index(%Conn{} = conn, %{} = params) do | ||
| with user_categorys <- UserCategory |> Query.id_filter(params) |> Repo.all do |
There was a problem hiding this comment.
Just a spelling thing, but it would be user_categories
landongrindheim
force-pushed
the
914-user-category-controller
branch
from
efd66e9 to
9c90e97
Compare
|
@begedin Thanks for catching that! I rebased, squashed and force pushed to this branch |
landongrindheim
force-pushed
the
914-user-category-controller
branch
from
9c90e97 to
d67d6db
Compare
joshsmith
approved these changes
Sep 20, 2017
|
@landongrindheim merged for you to avoid you needing a rebase again. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reliance on ja_resources and canary for UserCategoryController.
References
Closes #914
Progress on: #864