Remove TaskSkill reliance on ja_resource/canary

[landongrindheim]

Removes reliance and ja_resources and canary for the TaskSkillController

References

Closes #912

Progress on: #864

[begedin]

A minor change in the tests is needed, but otherwise looks great.

Don't forget to rebase and squash the commits as you make the change, for quick approval and merging from my side.

[begedin]

In "real-life", this function is being called from CodeCorps.Policy using a params map (with string keys) as the second argument.

However, the tests call it with a %TaskSkill{} with atom keys as the second argument.

The real life part is indirectly tested from the controller tests, and the tests you wrote here still pass, becase in CodeCorps.Policy.Helpers, we have

def get_task(%TaskSkill{task_id: task_id}), do: Repo.get(Task, task_id)
def get_task(%{"task_id" => task_id}), do: Repo.get(Task, task_id)

However, these tests leave room for a potential bug being introduced, so I would replace the second argument in create? tests with a params map. Note that the delete? tests do correctly use a %TaskSkill{} as the second argument, so there isn't anything to change there.

[landongrindheim]

@begedin Thanks for the feedback! The branch has been updated :)

[begedin]

@landongrindheim Thank you. Awesome work!

[joshsmith]

🙌 , as always. 🥇