Remove ProjectSkillController reliance on ja_resources/canary #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
requested changes
Sep 26, 2017
| end | ||
|
|
||
| @spec create?(User.t, ProjectSkill.t) :: boolean | ||
| def delete?(%User{} = user, %ProjectSkill{} = project_skill) do |
There was a problem hiding this comment.
Oops. I'll update today
landongrindheim
force-pushed
the
899-remove-reliance-on-ja-resources
branch
from
2b2ef2c to
7a9a326
Compare
|
@begedin Updated the spec: |
begedin
approved these changes
Sep 26, 2017
|
great work as usual @landongrindheim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
ProjectSkillControllerreliance onja_resources/canary.References
Closes #899
Progress on: #864