DTL (Test > Levelbuilder): cdc38773 #24839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bias the race condition in promise rejection, so it always resets `isCapturePending` after the next App Lab tick. Relying on async Promise resolution order is super fragile, especially when we mock setTimeout with `sinon.useFakeTimers`.
Ensure the promise doesn't reject in the same (simulated) tick as the current Applab.tickCount.
…you_do_not_do_anything in SessionCookieTest)
# Conflicts: # apps/src/StudioApp.js # apps/src/gamelab/GameLab.js # apps/test/unit/gamelab/GameLabTest.js
…rror, send load-sign-up-page on each reload
Track sign up details
DTT (Staging > Test) [robo-dtt]
Projects: project validators see view more links
i18n sync hourofcode.com down and out 09/11 - Spanish Only
I18n sync HOC In & Up 09/11
Render markdown with remark behind experiment flag
Move failed account takeover logging to redshift, include error
Clarify Release Records Procedure
DTT (Staging > Test) [robo-dtt]
…n-options Auto-quote dropdown options for string inputs
Add helper libraries to App Lab
Update AWS Firehose gem to 1.6
…-remove-production-dependency-on-metrics-database Revert "Revert "remove production dependency on internal metrics database""
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.