Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foorm: Add character limit to free responses #36458

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

molly-moen
Copy link
Contributor

In our bug bash we noticed there was no character limit on free response questions in Foorm. Added a character limit of 4000 based on this guidance

Links

Testing story

Tested free response questions are now limited to 4000 characters.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested a review from a team August 26, 2020 17:50
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what happens at this limit? Does the system simply truncate the text?

@molly-moen
Copy link
Contributor Author

Out of curiosity, what happens at this limit? Does the system simply truncate the text?

@breville yes, if you try to paste in > 4000 characters it will truncate at 4000, if you are typing in it won't let you type past 4000 characters.

@molly-moen molly-moen merged commit cb1f257 into staging Aug 27, 2020
@molly-moen molly-moen deleted the molly/foorm-comment-length branch August 27, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants