Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL (Test > Levelbuilder): 0dbd8797 #44905

Merged
merged 100 commits into from Feb 17, 2022
Merged

Conversation

deploy-code-org
Copy link
Contributor

No description provided.

Amy Gebhardt and others added 30 commits January 12, 2022 11:04
Rails 6 changed the way ActionView expects to be initialized. Within Pegasus, we are using a modified version of ActionView to render templates and so that modification needs to be updated.

The nature of our modification includes storing a reference to Sinatra within the instance of ActionView that we initialize; our original implementation simply added a new required initialization variable but the new Rails 6 initialization logic makes that more difficult. So instead, we manually set the instance variable after initialization. This is obviously much clumsier than the original approach, but should be easier to maintain.

The increased complexity of our new initialization logic is all captured in a new factory method.
to append https://videos.code.org in the levelbuilder URL

Co-authored-by: Bethany Connor <46464143+bethanyaconnor@users.noreply.github.com>
davidsbailey and others added 26 commits February 16, 2022 12:28
remove dead code related to certificate link test
DTT (Staging > Test) [robo-dtt]
Temporarily allowing diffs in the schema dump
DTT (Staging > Test) [robo-dtt]
…t-songs

[Higher Power/Dance Party] update levels and levelbuilder song manifest
DTT (Staging > Test) [robo-dtt]
Replace script ID with name in callouts tsv
Remove Event Param from OnBoardEvent [Circuit Playground]
[Maker][CP] - Use blank array param for buzzer
DTT (Staging > Test) [robo-dtt]
DTS (Levelbuilder > Staging) [objelisks]
Translation files for Coldplay launch (es-mx, pt-br, pl, de)
DTT (Staging > Test) [robo-dtt]
@deploy-code-org deploy-code-org requested review from a team as code owners February 17, 2022 23:20
@deploy-code-org deploy-code-org merged commit 3c24a21 into levelbuilder Feb 17, 2022
@deploy-code-org deploy-code-org deleted the dtl_candidate_0dbd8797 branch February 17, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet