Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL (Test > Levelbuilder): a00e5092 #45127

Merged
merged 37 commits into from
Mar 2, 2022

Conversation

deploy-code-org
Copy link
Contributor

No description provided.

Erin Peach and others added 30 commits February 18, 2022 15:06
DTT (Staging > Test) [robo-dtt]
…-progress-table

Report loading events for progress table to new relic
DTT (Staging > Test) [robo-dtt]
…eplay

Remove freeplay levels from uncacheable list
DTT (Staging > Test) [robo-dtt]
…218-cache-freeplay

Revert "Remove freeplay levels from uncacheable list"
DTT (Staging > Test) [robo-dtt]
After completing a comprehensive review of all allowed hostnames, the following five are being removed: 

1. apex.oracle.com - the documentation seems to indicate this would just allow for querying of a database the student/teacher has access to https://docs.oracle.com/en/database/oracle/application-express/20.2/aeapi/preface.html - given the risk for arbitrary content, removing (we also don't think students/teachers would have access to many if any Oracle databases to use this API).

2. enclout.com- this is a domain, Entity and Language processing API, we saw cert expired and thus are removing. 

3. herokuapp.com - it was unclear what the original reasoning for this hostname being added - the hostname is a risk to us allowing arbitrary content to be passed to App Lab and has caused multiple reports on the teacher forums.

4. pastebin.com - this API stores online text, removed as we do not want to support arbitrary text access in our allowed hostnames and such use cases can be met with the data tables in App Lab.

5. spreadsheets.google.com - This API no longer works as there are no references to it from https://developers.google.com/sheets/api/reference/rest and we know the sheets API does not work for us due to its forward redirects 

Zendesk ticket: https://codedotorg.atlassian.net/browse/STAR-2040
Erin Peach and others added 7 commits March 2, 2022 11:51
[micro:bit] Setup Checklist - Remove 4th Check
Remove multiple hostnames from startWebRequest
DTS (Levelbuilder > Staging) [robo-dts]
DTT (Staging > Test) [robo-dtt]
…-verified-students

Add notification for student with verified teacher permission
DTT (Staging > Test) [robo-dtt]
@deploy-code-org deploy-code-org requested a review from a team as a code owner March 2, 2022 23:20
@deploy-code-org deploy-code-org merged commit 5a84a6c into levelbuilder Mar 2, 2022
@deploy-code-org deploy-code-org deleted the dtl_candidate_a00e5092 branch March 2, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants