Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding two new video resources page urls to the landing pages ui test #59377

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Jun 24, 2024

This PR adds two new landing page UI tests to the list of tutorial landing page urls.

The first is the standard code.org/educate/resources/videos page, and the second helps test the youtube fallback scenario with the url http://code.org/educate/resources/videos?force_youtube_fallback=1.

I was able to verify from the Saucelabs drone run that both the standard and yt fallback pages load as expected. I'll be in touch with the DOTD about the new eyes baselines!

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam marked this pull request as ready for review June 24, 2024 23:23
@hannahbergam hannahbergam changed the title adding new landing page to check Adding two new video resources page urls to the landing pages ui test Jun 25, 2024
@hannahbergam hannahbergam requested a review from a team June 25, 2024 19:44
Copy link
Contributor

@kelbyhawn kelbyhawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool! 🤩 @dmcavoy this appears extremely easy to do for code.org pages — are there any others we should add UI tests on? (in a new PR of course)

@TurnerRiley
Copy link
Contributor

This is so cool! 🤩 @dmcavoy this appears extremely easy to do for code.org pages — are there any others we should add UI tests on? (in a new PR of course)

Wow this rules!!

@hannahbergam hannahbergam merged commit 82c719b into staging Jun 25, 2024
2 checks passed
@hannahbergam hannahbergam deleted the hbergam/new-landing-page-ui-test branch June 25, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants