Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address validation #97

Closed
coreyar opened this issue Sep 10, 2018 · 1 comment
Closed

Address validation #97

coreyar opened this issue Sep 10, 2018 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@coreyar
Copy link
Member

coreyar commented Sep 10, 2018

We allow for forms to be submitted with blank fields. This can cause issues with formatting the address.

Add validation that all or none of the form fields are required. We'll also need to add a blank field for the state dropdown or exclude it from the validation and form when validation shows all empty fields.

As a user filling out the form, I can submit the form with all address fields completed or none of them completed.

@coreyar coreyar added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 10, 2018
@coreyar coreyar added this to the V0.9 milestone Sep 10, 2018
@aaronpinch
Copy link
Collaborator

We need to omit the state name if the address is blank

Potential solutions - 1) if address is blank than state treated as blank 2) Don't autoselect TN on forms. Rather put it at the top of the dropdown

image

@coreyar coreyar removed the help wanted Extra attention is needed label Sep 13, 2018
@coreyar coreyar added the help wanted Extra attention is needed label Sep 29, 2018
coreyar pushed a commit that referenced this issue Mar 17, 2019
* Adding address validation

* Add back default state

* Update states.js

* Update states.js
@coreyar coreyar closed this as completed Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants