Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable dimensions #397

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Stable dimensions #397

merged 1 commit into from
Jul 5, 2023

Conversation

pomber
Copy link
Contributor

@pomber pomber commented Jul 5, 2023

Don't chante dimensions when the focus changes.

📦 Published PR as canary version: 0.9.1--canary.397.c7a9d9d.0

✨ Test out this PR locally via:

npm install @code-hike/mdx@0.9.1--canary.397.c7a9d9d.0
# or 
yarn add @code-hike/mdx@0.9.1--canary.397.c7a9d9d.0

Version

Published prerelease version: v0.9.1-next.4

Changelog

🐛 Bug Fix

⚠️ Pushed to next

  • Add backticks to release message (@pomber)

Authors: 2

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chtest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 11:01am
playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 11:01am

@pomber pomber added patch Increment the patch version when merged release Create a release when this pr is merged labels Jul 5, 2023
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

📦 Next.js Bundle Analysis for bundle-test

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/just-code 26.35 KB 101.04 KB 28.87% (+/- <0.01%)
/scrollycoding-preview 29.41 KB 104.1 KB 29.74% (+/- <0.01%)
/spotlight 26.9 KB 101.59 KB 29.03% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@pomber pomber merged commit 2049fb2 into next Jul 5, 2023
5 checks passed
@pomber pomber deleted the stable-focus-link branch July 5, 2023 11:10
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Released in v0.9.1-next.4 🚀

Thanks for using Code Hike! Become a sponsor and help us keep innovating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant