Skip to content

Remove fields from login protos #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Remove fields from login protos #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d1853
Remove fields from login protos
jeffyanta Jan 9, 2024
a2c2a09
Merge branch 'main' into updated-login-protos
jeffyanta Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
firebase.google.com/go/v4 v4.8.0
github.com/aws/aws-sdk-go-v2 v0.17.0
github.com/bits-and-blooms/bloom/v3 v3.1.0
github.com/code-payments/code-protobuf-api v1.5.0
github.com/code-payments/code-protobuf-api v1.6.0
github.com/emirpasic/gods v1.12.0
github.com/envoyproxy/protoc-gen-validate v0.1.0
github.com/golang-jwt/jwt/v5 v5.0.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ github.com/cncf/xds/go v0.0.0-20210922020428-25de7278fc84/go.mod h1:eXthEFrGJvWH
github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/cockroachdb/apd v1.1.0 h1:3LFP3629v+1aKXU5Q37mxmRxX/pIu1nijXydLShEq5I=
github.com/cockroachdb/apd v1.1.0/go.mod h1:8Sl8LxpKi29FqWXR16WEFZRNSz3SoPzUzeMeY4+DwBQ=
github.com/code-payments/code-protobuf-api v1.5.0 h1:zysEaGMfl4kcJcsO91VNBXkP9zFeG/nbChn4MycDW3s=
github.com/code-payments/code-protobuf-api v1.5.0/go.mod h1:pHQm75vydD6Cm2qHAzlimW6drysm489Z4tVxC2zHSsU=
github.com/code-payments/code-protobuf-api v1.6.0 h1:u+za1DMu7gyH9RqeAlpxtpe1QR57Yywq/Sh2d1MNT3k=
github.com/code-payments/code-protobuf-api v1.6.0/go.mod h1:pHQm75vydD6Cm2qHAzlimW6drysm489Z4tVxC2zHSsU=
github.com/containerd/continuity v0.0.0-20190827140505-75bee3e2ccb6 h1:NmTXa/uVnDyp0TY5MKi197+3HWcnYWfnHGyaFthlnGw=
github.com/containerd/continuity v0.0.0-20190827140505-75bee3e2ccb6/go.mod h1:GL3xCUCBDV3CZiTSEKksMWbLE66hEyuu9qyDOOqM47Y=
github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk=
Expand Down
2 changes: 0 additions & 2 deletions pkg/code/server/grpc/messaging/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,6 @@ func TestSendMessage_RequestToLogin_HappyPath(t *testing.T) {
require.NotNil(t, savedProtoMessage.GetRequestToLogin())
assert.Equal(t, sendMessageCall.req.Message.GetRequestToLogin().Verifier.Value, savedProtoMessage.GetRequestToLogin().Verifier.Value)
assert.Equal(t, sendMessageCall.req.Message.GetRequestToLogin().Domain.Value, savedProtoMessage.GetRequestToLogin().Domain.Value)
assert.Equal(t, sendMessageCall.req.Message.GetRequestToLogin().Nonce.Value, savedProtoMessage.GetRequestToLogin().Nonce.Value)
assert.Equal(t, sendMessageCall.req.Message.GetRequestToLogin().Signature.Value, savedProtoMessage.GetRequestToLogin().Signature.Value)
assert.Equal(t, sendMessageCall.req.Message.GetRequestToLogin().RendezvousKey.Value, savedProtoMessage.GetRequestToLogin().RendezvousKey.Value)
assert.Equal(t, sendMessageCall.req.Signature.Value, savedProtoMessage.SendMessageRequestSignature.Value)
Expand Down Expand Up @@ -678,7 +677,6 @@ func TestSendMessage_LoginAttempt_HappyPath(t *testing.T) {
require.NotNil(t, savedProtoMessage.GetLoginAttempt())
assert.Equal(t, sendMessageCall.req.Message.GetLoginAttempt().UserId.Value, savedProtoMessage.GetLoginAttempt().UserId.Value)
assert.Equal(t, sendMessageCall.req.Message.GetLoginAttempt().Domain.Value, savedProtoMessage.GetLoginAttempt().Domain.Value)
assert.Equal(t, sendMessageCall.req.Message.GetLoginAttempt().Nonce.Value, savedProtoMessage.GetLoginAttempt().Nonce.Value)
assert.Equal(t, sendMessageCall.req.Message.GetLoginAttempt().Signature.Value, savedProtoMessage.GetLoginAttempt().Signature.Value)
assert.Equal(t, sendMessageCall.req.Message.GetLoginAttempt().RendezvousKey.Value, savedProtoMessage.GetLoginAttempt().RendezvousKey.Value)
assert.Equal(t, sendMessageCall.req.Signature.Value, savedProtoMessage.SendMessageRequestSignature.Value)
Expand Down
4 changes: 0 additions & 4 deletions pkg/code/server/grpc/messaging/testutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,8 +801,6 @@ func (c *clientEnv) sendRequestToLoginMessage(t *testing.T, rendezvousKey *commo
Domain: &commonpb.Domain{
Value: "app.getcode.com",
},
Nonce: testutil.NewRandomAccount(t).ToProto(),
Timestamp: timestamppb.Now(),
RendezvousKey: &messagingpb.RendezvousKey{
Value: rendezvousKey.PublicKey().ToBytes(),
},
Expand Down Expand Up @@ -868,8 +866,6 @@ func (c *clientEnv) sendLoginAttemptMessage(t *testing.T, rendezvousKey *common.
Domain: &commonpb.Domain{
Value: "app.getcode.com",
},
Nonce: testutil.NewRandomAccount(t).ToProto(),
Timestamp: timestamppb.Now(),
RendezvousKey: &messagingpb.RendezvousKey{
Value: rendezvousKey.PublicKey().ToBytes(),
},
Expand Down