Skip to content

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 3, 2025

This PR make targets cacheable again.

Copy link

nx-cloud bot commented Sep 3, 2025

View your CI Pipeline Execution ↗ for commit e9c6162

Command Status Duration Result
nx code-pushup --nx-bail -- compare --verbose ✅ Succeeded 20s View ↗
nx code-pushup --nx-bail -- --verbose ✅ Succeeded 28s View ↗
nx code-pushup --nx-bail -- print-config --verb... ✅ Succeeded 10m 17s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 01:50:01 UTC

Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1101

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1101

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1101

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1101

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1101

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1101

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1101

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1101

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1101

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1101

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1101

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1101

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1101

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1101

commit: e9c6162

@github-actions github-actions bot added the 🦾 CI/CD Continuous integration and deployment label Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Code PushUp

🥳 Code PushUp report has improved – compared current commit 3df8d0a with previous commit b85316d.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🔴 30 🔴 33 ↑ +2.9
Code coverage 🟢 90 🟢 90 ↑ +0.1
Security 🟡 64 🟡 64
Updates 🟡 85 🟡 85
Accessibility 🟢 92 🟢 92
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Type Safety 🟢 100 🟢 100
Bug prevention 🟢 100 🟢 100
Miscellaneous 🟢 100 🟢 100
Code style 🟢 100 🟢 100
Documentation 🔴 23 🔴 23
👍 2 groups improved, 👍 6 audits improved, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🔴 30 🔴 33 ↑ +2.9
Code coverage Code coverage metrics 🟢 90 🟢 90 ↑ +0.1

19 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Speed Index 🟥 8.3 s 🟥 6.9 s ↓ −16.1 %
Lighthouse First Contentful Paint 🟥 3.6 s 🟥 3.2 s ↓ −12.2 %
Lighthouse Time to Interactive 🟥 18.8 s 🟥 16.6 s ↓ −11.7 %
Lighthouse Total Blocking Time 🟥 5,420 ms 🟥 3,650 ms ↓ −32.7 %
Code coverage Line coverage 🟨 87.4 % 🟨 87.5 % ↑ +0.1 %
Code coverage Branch coverage 🟨 86.3 % 🟨 86.3 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟨 Total size was 2,680 KiB 🟨 Total size was 2,674 KiB ↓ −0.2 %
Lighthouse Minimizes main-thread work 🟥 17.7 s 🟥 12.8 s ↓ −27.5 %
Lighthouse JavaScript execution time 🟥 7.7 s 🟥 4.8 s ↓ −37.7 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −11.7 %
Lighthouse Largest Contentful Paint 🟥 12.4 s 🟥 11.3 s ↓ −9.1 %
Lighthouse Server Backend Latencies 🟩 1,670 ms 🟩 1,120 ms ↓ −33.2 %
Lighthouse Uses efficient cache policy on static assets 🟨 31 resources found 🟨 31 resources found ↑ +0.1 %
Lighthouse Max Potential First Input Delay 🟥 1,700 ms 🟥 1,520 ms ↓ −10.2 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 583 KiB 🟥 Potential savings of 583 KiB ↑ +15 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 10 ms ↓ −87.6 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 113 KiB 🟥 Potential savings of 113 KiB ↓ −4.7 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 101 KiB 🟥 Potential savings of 85 KiB ↓ −3.1 %
Lighthouse Initial server response time was short 🟩 Root document took 370 ms 🟩 Root document took 370 ms ↑ +1.8 %

591 other audits are unchanged.

@BioPhoton BioPhoton marked this pull request as ready for review September 3, 2025 01:40
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but be aware that we can't trust Nx cache at the moment:

@BioPhoton BioPhoton merged commit aa4540a into main Sep 3, 2025
18 checks passed
@BioPhoton BioPhoton deleted the fix/chore/test-caching branch September 3, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🦾 CI/CD Continuous integration and deployment 🛠️ tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants