Skip to content

생성자의 인자에서 바로 프로퍼티를 정의하도록 변경합니다. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

code-yeongyu
Copy link
Owner

  • PageInteractor 생성자에서 인자로 받으며 프로퍼티 정의 하도록 변경
  • ElementParser 생성자에서 인자로 받으며 프로퍼티 정의 하도록 변경
  • Service 생성자에서 인자로 받으며 프로퍼티 정의 하도록 변경
  • URLChanger 생성자에서 인자로 받으며 프로퍼티 정의 하도록 변경

@codecov-commenter
Copy link

Codecov Report

Merging #7 (ed868cc) into master (5ff7831) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   43.75%   43.75%           
=======================================
  Files           3        3           
  Lines          32       32           
=======================================
  Hits           14       14           
  Misses         18       18           
Impacted Files Coverage Δ
src/app/naver/service.ts 0.00% <0.00%> (ø)
src/app/naver/urlChanger.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff7831...ed868cc. Read the comment docs.

@code-yeongyu code-yeongyu merged commit 49d5d2a into master Jan 20, 2022
@code-yeongyu code-yeongyu deleted the improve-readability-constructor branch January 20, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants