Skip to content

main 실행시 출력되는 문구를 변경합니다. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

code-yeongyu
Copy link
Owner

Comment on lines -2 to +4
print("Hello, world!")
print('연규컴퍼니')
# 왜 hello world 가 아니라 연규컴퍼니 인가요?
# https://github.com/code-yeongyu/comment-python-project/wiki/%EA%B8%B0%EB%B3%B8-%ED%85%9C%ED%94%8C%EB%A6%BF-%EC%8B%A4%ED%96%89-%EB%AC%B8%EA%B5%AC-%EA%B4%80%EB%A0%A8-%EB%85%BC%EC%9D%98-%EB%82%B4%EC%9A%A9
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰어: 이렇게 되면 print 의 문구가 변경되거나 기본 main 의 동작이 바뀔때마다 주석을 따로 관리해줘야 할텐데요, 에디터에서 아래와 같이 연결된 PR 을 쉽게 볼 수 있습니다.

만약 이 main 의 동작이 바뀌거나 문구가 변경되면 '연규컴퍼니' 에 대한 맥락은 필요가 없고, 자연스레 최신버전의 코드에서는 나타나지 않을테니 관리 포인트에 대한 염려도 없습니다.

Screenshot 2023-02-06 at 18 28 09

해당 주석은 제거하는것이 어떨까요?

@code-yeongyu code-yeongyu merged commit 16ec11a into master Feb 6, 2023
@code-yeongyu code-yeongyu deleted the feature/main-print branch February 6, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant