Skip to content

[pull] main from microsoft:main #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"@zip.js/zip.js": "^2.7.29",
"ansi-styles": "^4.3.0",
"chokidar": "^3.5.3",
"chromium-bidi": "^5.3.1",
"chromium-bidi": "^7.2.0",
"colors": "^1.4.0",
"concurrently": "^6.2.1",
"cross-env": "^7.0.3",
Expand Down
4 changes: 3 additions & 1 deletion tests/library/inspector/cli-codegen-2.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ var page1 = await context.NewPageAsync();`);
await page.CloseAsync();`);
});

test('should not lead to an error if html gets clicked', async ({ openRecorder }) => {
test('should not lead to an error if html gets clicked', async ({ openRecorder, platform, macVersion }) => {
test.skip(platform === 'darwin' && macVersion < 15, 'recorder.page.evaluate hangs on CDP layer for some reason on macOS 14.');

const { page, recorder } = await openRecorder();

await recorder.setContentAndWait('');
Expand Down
6 changes: 3 additions & 3 deletions tests/library/inspector/recorder-api.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ test('should click', async ({ context, browserName, platform }) => {
selector: 'internal:role=button[name="Submit"i]',
ref: 'e2',
// Safari does not focus after a click: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/button#clicking_and_focus
ariaSnapshot: (browserName === 'webkit' && platform === 'darwin') ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
ariaSnapshot: (browserName === 'webkit' && (platform === 'darwin' || platform === 'win32')) ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
}),
startTime: expect.any(Number),
})
Expand All @@ -84,7 +84,7 @@ test('should double click', async ({ context, browserName, platform }) => {
selector: 'internal:role=button[name="Submit"i]',
ref: 'e2',
// Safari does not focus after a click: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/button#clicking_and_focus
ariaSnapshot: (browserName === 'webkit' && platform === 'darwin') ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
ariaSnapshot: (browserName === 'webkit' && (platform === 'darwin' || platform === 'win32')) ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
}),
startTime: expect.any(Number),
})
Expand All @@ -108,7 +108,7 @@ test('should right click', async ({ context, browserName, platform }) => {
selector: 'internal:role=button[name="Submit"i]',
ref: 'e2',
// Safari does not focus after a click: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/button#clicking_and_focus
ariaSnapshot: (browserName === 'webkit' && platform === 'darwin') ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
ariaSnapshot: (browserName === 'webkit' && (platform === 'darwin' || platform === 'win32')) ? '- button "Submit" [ref=e2]' : '- button "Submit" [active] [ref=e2]',
}),
startTime: expect.any(Number),
})
Expand Down
Loading