-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(ui): add a visual download PDF feature #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@hkirat could you please review it? |
My.Movie.mp4 |
@hkirat ping for attention. could you please review this?? |
great work can you fix the file name as the page title? |
Hi so sorry not getting the time to review |
Yea, sure thanks for the suggestion |
@devsargam Please ensure all content within toogle buttons is also printed in the pdf. P.S: Even when I opened the toggle buttons, the code opens a new page for printing with all the toggle buttons closed. Also pdf doesn't support text search as well. |
Alright I'll work on it right now thanks for the bug |
@mumin-khan please check. I've fixed the solution now showing up issue now. |
@devsargam It works now. Also the track and pdf routes have almost the same code. It would be better to refactor the code to avoid duplication. |
|
I would respectfully disagree with your opinion here. I think you are passing the same problemDetail for all pages in a track. |
@devsargam can u fix the merge conflicts |
hey @hkirat, I've done my part. |
merged in a few PRs, might've broken something |
or did u change something related to firebase or notion? |
Also, you can merge this @hkirat |
Hey @devsargam |
@AdiGaikwad yeppp, seems something is wrong I'm investigating |
But it does give correct for few cases right? |
I checked for 2 tracks both of them gave a blank page |
Hey, @devsargam the solutions are not opening on the website. It's working locally but in the production, it doesn't |
There is a pr which hopefully fixes that @thrishank |
Fixes: #55
This pr adds:
/pdf/.../...
to convert notion doc to pdfMy approach to this problem:
pdf/.../...