Handle begin date complications #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
changed the title
added 3 commits
March 9, 2020 13:52
antazoey
commented
Mar 9, 2020
antazoey
commented
Mar 9, 2020
alanag13
suggested changes
Mar 9, 2020
README.md
Outdated
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| Use the `code42` command to interact with your Code42 environment. | |||
| `code42 securitydata` is a CLI tool for extracting AED events. | |||
| Additionally, `code42 securitydata` can record a checkpoint so that you only get events you have not previously gotten. | |||
| Additionally, `code42 securitydata` can record a checkpoint so that you only get events you have not previously gotten | |||
There was a problem hiding this comment.
I would phrase this as you only get events that were reported to Code42 since the previous time you recorded a checkpoint.
There was a problem hiding this comment.
How about you only get events that Code42 previously did not observe since you last recorded a checkpoint ?
alanag13
suggested changes
Mar 10, 2020
src/code42cli/util.py
Outdated
|
|
||
| def get_url_parts(url_str): | ||
| parts = url_str.split(u":") | ||
| if parts[0] == u"http" or parts[0] == u"https": |
There was a problem hiding this comment.
this could be any protocol, not just http or https (sftp://, ftp:// ssh:// are all valid, for example).
It would probably be easier to use some thing like urlparse and do something like
parsed_host = urlparse(url_str)
return parsed_host.netloc #(string that contains domain and port).You could wrap that whole thing in a try/catch to error out on invalid addresses that can't be parsed
added 2 commits
March 10, 2020 21:12
alanag13
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.