Added code to write to STDERR when no results found #22
Conversation
| @@ -144,6 +145,8 @@ def handle_response(response): | |||
| events = response_dict.get(u"fileEvents") | |||
| for event in events: | |||
| output_logger.info(event) | |||
| if not len(events): | |||
There was a problem hiding this comment.
This will print for every page of response. Also, if the last page has 0 results, and the first page had 10000 results, this will also print this error message.
What we need to do is something similar to the variable global _EXCEPTIONS_OCCURRED at lie 132.
There was a problem hiding this comment.
Sorry, it won't print for every page of response, just the last one if it was empty, which is still unexpected
There was a problem hiding this comment.
Changed, used global variable.
|
We need a CHANGELOG entry for this too |
Added changelog. |
| for event in events: | ||
| output_logger.info(event) | ||
|
|
||
| if not _TOTAL_EVENTS: |
There was a problem hiding this comment.
This will work but it is a little confusing.
Can you move this to the _handle_result() function?
There was a problem hiding this comment.
Everything in handle_response should just be page-relevant stuff. Side-effects are a necessary evil right now.
| @@ -170,6 +173,9 @@ def _verify_compatibility_with_advanced_query(key, val): | |||
| def _handle_result(): | |||
| if is_interactive() and _EXCEPTIONS_OCCURRED: | |||
| print_error(u"View exceptions that occurred at [HOME]/.code42cli/log/code42_errors.") | |||
| global _TOTAL_EVENTS | |||
There was a problem hiding this comment.
The global here is not really needed but that is ok
kiran-chaudhary
force-pushed
the
integ-935-write-no-result-to-stderr
branch
from
e59aef0 to
50b9b50
Compare
Tested method for
print, expecting behaviour to be consistent forsend-toandwrite-to.Did not add tests, as it is writing to STDERR