Fix intermittent send-to integration failures #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prevent intermittent connection problems
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
antazoey
approved these changes
Mar 2, 2021
antazoey
reviewed
Mar 2, 2021
| def test_auditlogs_send_to_command_returns_success_return_code( | ||
| runner, integration_test_profile, protocol | ||
| def test_auditlogs_send_to_tcp_command_returns_success_return_code( | ||
| runner, integration_test_profile, tcp_dataserver |
There was a problem hiding this comment.
Do actually need to pass this in or will it work without it?
There was a problem hiding this comment.
I believe it should work without passing them in as fixture params
There was a problem hiding this comment.
The tcp_dataserver and udp_dataserver fixtures are what I am referring to
There was a problem hiding this comment.
If no tests use the fixture, it won't get set up unless we set autouse=True on it. Which we don't want, since we only want it to get set up on integration tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the DataServers into session-scoped fixtures with different ports to prevent intermittent connection problems, since they'll only be setup/torn down once per run.