pin click version to fix failing tests #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
alanag13
commented
May 12, 2021
setup.py
Outdated
| "click_plugins>=1.1.1", | ||
| "colorama>=0.4.3", | ||
| "c42eventextractor==0.4.1", | ||
| "keyring==18.0.1", | ||
| "keyrings.alt==3.2.0", | ||
| "pandas>=1.1.3", | ||
| "py42>=1.11.1", | ||
| "py42>=1.13.0", |
There was a problem hiding this comment.
I also found that the current min py42 version is wrong, 1.13.0 added some methods that the latest CLI release uses
There was a problem hiding this comment.
woops nvm this was caused by my branch not being caught up
peterbriggs42
approved these changes
May 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click 8.0 was released ~14hrs ago and is causing unit tests to fail due to some breaking changes it made. We should eventually try to update to the latest and greatest and make the appropriate corresponding changes but for now let's just get everything to pass again.