Skip to content

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Jul 8, 2021

Fixes some Audit Log bugs as well as new Users Commands

@antazoey antazoey requested a review from a team as a code owner July 8, 2021 18:49
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@@ -33,8 +33,6 @@ how a consumer would use the library (e.g. adding unit tests, updating documenta

### Changed

- `code42 alerts search` now uses microsecond precision when searching by alerts' date observed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not appear to be true for some reason, so removing it for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not true in the sense that when I do -b "2021-07-06 12:23:23.235322", it is sent as 2021-07-06T12:23:23.000000Z

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would need to be updated to allow for sub-second precision:

https://github.com/code42/code42cli/blob/main/src/code42cli/click_ext/types.py#L123-L130

@antazoey antazoey changed the title Release prep - 1.8.0 Fixes some Audit Log bugs as well as new Users Commands Release prep - 1.8.0 Jul 8, 2021
@antazoey antazoey merged commit 9946ade into main Jul 8, 2021
@antazoey antazoey deleted the release-prep branch July 8, 2021 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants