Skip to content

Assorted doc improvements, mostly to ActiveRecordWrapper #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2019

Conversation

jrochkind
Copy link
Collaborator

@jrochkind jrochkind commented Aug 22, 2019

Run across when using docs to implement ActiveRecordWrapper in app.

It wasn't necessary in Rails 3\!
Take advantage of newer Rails strong params, but also passing strong params in directly like previous example actually messes up the <request> element in response.

We should probably debug and fix that, but don't have capacity at present.
@jrochkind jrochkind merged commit f95f80c into master Aug 22, 2019
@jrochkind jrochkind deleted the more_docs branch August 22, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant