Add tests and types #196
Merged
Add tests and types #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remnantdotdev
commented
Feb 8, 2022
| indexes_to_remove.push(index); | ||
| meeting.day.forEach(day => { | ||
| meetings_to_add.push({ | ||
| ...meeting, |
There was a problem hiding this comment.
If I'm understanding the intent of flattenDays correctly, I'm not sure this function was ever working since the ...meeting was overriding the day and slug set 👀
There was a problem hiding this comment.
haha 🤦
the intent of this function is to allow people to have a JSON feed that has day: [0, 1, 2] or a Google Sheet that has day = Sunday, Monday, Tuesday -- but it's very infrequently used so i'm not surprised it was a lurking bug. glad you found it!
remnantdotdev
commented
Feb 8, 2022
|
|
||
| indexes_to_remove.forEach(index => { | ||
| data = data.splice(index, 1); | ||
| data.splice(index, 1); |
There was a problem hiding this comment.
and data = data.splice(index, 1); was adding the newly created objects with the old one instead of mutating in place
joshreisner
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.