Skip to content

fixing clickability of in-progress row #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

fixing clickability of in-progress row #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc51e5
last quick fix on in progress css
joshreisner Feb 24, 2022
32a7182
Merge branch 'main' into jr/table-tests
joshreisner Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/app.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion public/style.css
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions src/components/Table.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,10 @@ export default function Table({
const meeting = state.meetings[slug];
return (
<tr
className="d-block d-md-table-row"
className={cx(
{ 'cursor-pointer': !listButtons },
'd-block d-md-table-row'
)}
onClick={() => {
if (listButtons) return;
setState({
Expand Down Expand Up @@ -152,7 +155,7 @@ export default function Table({
<div className="alert alert-warning m-0 opacity-50 p-2 rounded-0">
<button
onClick={() => setShowInProgress(true)}
className="alert-link bg-transparent border-0 d-block fw-normal mx-auto py-2 py-md-1 text-center text-decoration-underline"
className="alert-link bg-transparent border-0 d-block fw-normal mx-auto py-2 py-md-1 text-center text-decoration-underline w-100"
>
{inProgress.length === 1
? strings.in_progress_single
Expand Down
14 changes: 2 additions & 12 deletions src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,18 +289,8 @@ div.tsml-ui {
}

//when whole row is clickable
&.clickable-rows tbody {
tr:hover {
cursor: pointer;
a {
color: $blue-700;
}
}
&.tsml-in-progress tr:hover {
a {
color: $yellow-800;
}
}
&.clickable-rows tbody tr:hover a {
color: $blue-700;
}

//mobile view
Expand Down