Skip to content

Conversation

joshreisner
Copy link
Contributor

this PR fixes two bugs i noticed in the "near me/location" behavior.

  1. it was hiding empty distance options, meaning that if you used distance and filtered to no results and then reloaded the page, you could get into a weird state (fixes Show empty distance options #230)
  2. if you change to "near me/location" mode and picked a distance, then changed your mode back to search, you would see the word "within" dangling in the title, eg "Meetings in Los Gatos within"

additionally, it

  • fixes the flicker you see when loading a page with location already set. it used to render results and then re-render after getting geo and setting distances, now it waits
  • removes unused "no code api" endpoint parsing
  • makes distance options user-configurable
  • moves setMinutesNow functionality into filterMeetingData (locating all now-based calculations to that function)
  • simplifies logic in filterMeetingData

@joshreisner joshreisner self-assigned this May 22, 2022
@joshreisner joshreisner merged commit 7774b31 into main May 22, 2022
@joshreisner joshreisner deleted the jr/distance-refactor branch October 16, 2022 00:49
joshreisner added a commit that referenced this pull request Jun 2, 2023
* showing empty distance options for #230

* refactoring filterMeetingData

* refactoring time sort

* refactoring ready state, mode change bug

* fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show empty distance options

1 participant