Fix build of directions URL for Google Maps #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.2.6+ is required for react 17+
Previous build parameters led to inconsistent starting location. This form aligns with Google's current guidance.
Addresses the changes it appears Google has made for how directions' URLs should be generated. Closes Issue #236
|
thanks @tim-rohrer for taking the lead on this. we'll need to test on mobile devices before we can move this forward |
|
i've deployed this change now to netlify. san jose meeting list can be seen at https://62ebf555b6e86b35c23823b3--tsml-ui.netlify.app/tests/aasanjose.html tested on
i don't think this will really solve the issue the OP reported; desktop directions are iffy due to lack of GPS. but it's great to stay on top of API updates… |
joshreisner
approved these changes
Aug 4, 2022
joshreisner
added a commit
that referenced
this pull request
Jun 2, 2023
* chore: Bump react-infinite-scroller. v1.2.6+ is required for react 17+ * fix: Change directions URL build Previous build parameters led to inconsistent starting location. This form aligns with Google's current guidance. * fix: Change build of Google directions. Addresses the changes it appears Google has made for how directions' URLs should be generated. Closes Issue #236 * fix tests, update ios directions Co-authored-by: Josh Reisner <1551689+joshreisner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Discussion code4recovery/12-step-meeting-list#857 .
Google Maps has changed the way URLs are built for getting directions. This PR updates TSML-UI to the current Google guidance.
This was tested with Chrome on a laptop. It still needs to be tested on a site using a mobile device.